Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cross peer dependency for @waku packages #1889

Merged
merged 11 commits into from
Mar 12, 2024
Merged

feat: add cross peer dependency for @waku packages #1889

merged 11 commits into from
Mar 12, 2024

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Mar 6, 2024

Problem

Package discrepancy might occur.
More details - #1872

Solution

Add peerDependency

Notes

@weboko weboko requested a review from a team as a code owner March 6, 2024 00:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 185.23 KB (0%) 3.8 s (0%) 1.8 s (-38.61% 🔽) 5.5 s
Waku Simple Light Node 185.28 KB (0%) 3.8 s (0%) 1.7 s (-18.89% 🔽) 5.4 s
ECIES encryption 22.89 KB (0%) 458 ms (0%) 435 ms (-26.7% 🔽) 893 ms
Symmetric encryption 22.34 KB (0%) 447 ms (0%) 518 ms (-30% 🔽) 965 ms
DNS discovery 69.95 KB (0%) 1.4 s (0%) 1.4 s (-12.4% 🔽) 2.8 s
Privacy preserving protocols 39.96 KB (0%) 800 ms (0%) 1.1 s (+10.32% 🔺) 1.9 s
Waku Filter 20.11 KB (0%) 403 ms (0%) 291 ms (-41.58% 🔽) 693 ms
Waku LightPush 115.49 KB (0%) 2.4 s (0%) 2 s (+77.62% 🔺) 4.4 s
History retrieval protocols 19.34 KB (0%) 387 ms (0%) 356 ms (-4.33% 🔽) 743 ms
Deterministic Message Hashing 4.96 KB (0%) 100 ms (0%) 63 ms (+20.39% 🔺) 162 ms

danisharora099
danisharora099 reviewed Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@danisharora099 danisharora099 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this PR ready to be reviewed?

danisharora099
danisharora099 reviewed Mar 11, 2024
View reviewed changes
packages/tests/tests/store/error_handling.node.spec.ts Outdated
@@ -60,7 +60,7 @@ describe("Waku Store, error handling", function () {
TestDecoder,
customDecoder1
])) {
msgPromises;
await Promise.all(msgPromises);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we are awaiting for promises, instead of just ignoring them (before)

What changed with this PR that caused this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check started to fail and it seems due to minor update - #1895

@weboko weboko force-pushed the weboko/peer-deps branch from 3b5c44c to 24611fa Compare March 12, 2024 00:41
@weboko weboko merged commit 8f86740 into master Mar 12, 2024
9 of 10 checks passed
@weboko weboko deleted the weboko/peer-deps branch March 12, 2024 01:18
@weboko weboko mentioned this pull request Mar 12, 2024
Closed
This was referenced Apr 7, 2024
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danisharora099 danisharora099 danisharora099 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: peer lock @waku/* package versions
2 participants
@weboko @danisharora099