test: sharding tests refactor #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
fbarbu15
commented
Mar 13, 2024
| @@ -66,7 +66,8 @@ export const shardInfoToPubsubTopics = ( | |||
| // Autosharding: single shard from application and version | |||
| return [ | |||
| contentTopicToPubsubTopic( | |||
| `/${shardInfo.application}/${shardInfo.version}/default/default` | |||
| `/${shardInfo.application}/${shardInfo.version}/default/default`, | |||
| shardInfo.clusterId | |||
There was a problem hiding this comment.
I think we need this fix here because Autosharding is possible on other clusterIds
fbarbu15
commented
Mar 13, 2024
| @@ -293,7 +294,8 @@ export const ensureShardingConfigured = ( | |||
|
|
|||
| if (isApplicationVersionConfigured) { | |||
| const pubsubTopic = contentTopicToPubsubTopic( | |||
| `/${application}/${version}/default/default` | |||
| `/${application}/${version}/default/default`, | |||
| clusterId | |||
danisharora099
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
So I've skipped autosharding tests until js-waku uses 0.27.0
can we open an issue to track this? (put it in the blocked column on the board)
clusterID 1 is reserved for TWN and it uses RLN-RELAY by default while we don't have RLN support yet in this framework (and thus nwaku will not start and fail the tests)
this is being tracked in #1914
Added Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packages/utils/src/common/sharding.spec.tspackages/tests/tests/sharding/Issues found: