Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lightpush & filter send requests to multiple peers #1779

Merged
merged 30 commits into from
Jan 24, 2024
Merged
Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
1044f38
feat: lightpush & filter send requests to multiple peers
danisharora099 Jan 10, 2024
00e6703
build message-hash before core
danisharora099 Jan 11, 2024
6d5d5e2
chore: restructure folder heirrarchy
danisharora099 Jan 16, 2024
ec2905a
fix: imports
danisharora099 Jan 16, 2024
21d4d99
Merge branch 'master' into chore/refactors-test-suite
danisharora099 Jan 16, 2024
0e62ec2
Merge branch 'chore/refactors-test-suite' of github.com:waku-org/js-w…
danisharora099 Jan 16, 2024
9e3efa7
chore: move @waku/core to dev deps
danisharora099 Jan 16, 2024
634ca6e
feat: create a new `ServiceNodes` wrapper class to encapsulate servic…
danisharora099 Jan 16, 2024
7d9cd5f
chore(filter): move tests against single service node to a subdir
danisharora099 Jan 16, 2024
731499d
feat: support relay, add strict checking, add tests
danisharora099 Jan 17, 2024
7bc9c0b
fix(filter): handle errors
danisharora099 Jan 17, 2024
0d0b052
chore(tests): add tests for ping
danisharora099 Jan 17, 2024
bd38b8b
add tests for push
danisharora099 Jan 17, 2024
d0a0c1d
chore: abstract redundancy
danisharora099 Jan 17, 2024
e49fe46
feat: add unsubscribe tests
danisharora099 Jan 17, 2024
5a88d4b
Merge branch 'master' of github.com:waku-org/js-waku into feat/redund…
danisharora099 Jan 17, 2024
f2e66a6
fix: tests
danisharora099 Jan 17, 2024
9924f11
add lightpush tests
danisharora099 Jan 17, 2024
fbc724b
Merge branch 'master' of github.com:waku-org/js-waku into feat/redund…
danisharora099 Jan 17, 2024
ad66a8d
Merge branch 'master' of github.com:waku-org/js-waku into feat/redund…
danisharora099 Jan 17, 2024
c0b89ac
fix: imports
danisharora099 Jan 18, 2024
8e2cd80
Merge branch 'master' of github.com:waku-org/js-waku into feat/redund…
danisharora099 Jan 18, 2024
28de697
fix: merge & add warning
danisharora099 Jan 19, 2024
99c7cbe
merge: master
danisharora099 Jan 19, 2024
086e893
Merge branch 'master' of github.com:waku-org/js-waku into feat/redund…
danisharora099 Jan 19, 2024
a5ddd99
fix: breaking tests with master
danisharora099 Jan 19, 2024
bb99724
address comments
danisharora099 Jan 24, 2024
86642a0
Merge branch 'master' of github.com:waku-org/js-waku into feat/redund…
danisharora099 Jan 24, 2024
752fe50
make num peers configurable
danisharora099 Jan 24, 2024
1fc77db
fix: typo
danisharora099 Jan 24, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
"workspaces": [
"packages/interfaces",
"packages/utils",
"packages/message-hash",
"packages/proto",
"packages/enr",
"packages/core",
"packages/relay",
"packages/message-hash",
"packages/peer-exchange",
"packages/dns-discovery",
"packages/message-encryption",
Expand Down
1 change: 1 addition & 0 deletions packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
"@noble/hashes": "^1.3.2",
"@waku/enr": "^0.0.20",
"@waku/interfaces": "0.0.21",
"@waku/message-hash": "^0.1.10",
"@waku/proto": "0.0.6",
"@waku/utils": "0.0.14",
"debug": "^4.3.4",
Expand Down
7 changes: 7 additions & 0 deletions packages/core/src/lib/base_protocol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { StreamManager } from "./stream_manager.js";
export class BaseProtocol implements IBaseProtocol {
public readonly addLibp2pEventListener: Libp2p["addEventListener"];
public readonly removeLibp2pEventListener: Libp2p["removeEventListener"];
readonly NUM_PEERS_TO_USE = 3;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it not configurable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. made it configurable!

protected streamManager: StreamManager;
protected pubsubTopics: PubsubTopic[];

Expand Down Expand Up @@ -124,6 +125,12 @@ export class BaseProtocol implements IBaseProtocol {
);
}

if (sortedFilteredPeers.length < numPeers) {
this.log.warn(
`Only ${sortedFilteredPeers.length} peers found. Requested ${numPeers}.`
);
}

return sortedFilteredPeers;
}

Expand Down
Loading
Loading