fix: enable logging for npm install action #1559
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Due to broken behavior of
npm
action release PR was broken and wasn't able to succeed due tonpm ci
not working on release. It is expected because ofpackage-lock
andpackage
filed being out of sync sonpm i
should be used. For some reason action was misfunctioning and usingnpm ci
.My guess right now is that for some reason
github.ref
context is not in a form of branch (like if was before) but in a form ofrefs/pull/1559/merge
the action wrongly usesnpm ci
on release PR, which it shouldn't.Solution
Make use of a following pseudo-code:
For now just enabling debugging in CI to observe.
And yes, it would be good to keep using
npm ci
to reduce downloading packages each time.Notes