Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: peer lock @waku/* package versions #1872

Closed
weboko opened this issue Feb 29, 2024 · 0 comments · Fixed by #1889
Closed

feat: peer lock @waku/* package versions #1872

weboko opened this issue Feb 29, 2024 · 0 comments · Fixed by #1889
Assignees
@weboko
Labels
enhancement New feature or request

Comments

@weboko
Copy link
Collaborator

weboko commented Feb 29, 2024

This is a change request

Problem

Sometimes consumers face bugs that appear due to incompatibility of @waku/* packages in one project.
Example: @waku/[email protected] used alongside with @waku/[email protected].

Proposed Solutions

Add peerDependency as it is done in here and make sure release-please bumps them as well as regular dependency links.
@weboko weboko added the enhancement New feature or request label Feb 29, 2024
@weboko weboko self-assigned this Feb 29, 2024
@weboko weboko added this to Waku Feb 29, 2024
@weboko weboko moved this to In Progress in Waku Feb 29, 2024
@weboko weboko moved this from In Progress to Code Review / QA in Waku Mar 6, 2024
@weboko weboko mentioned this issue Mar 6, 2024
Merged
@github-project-automation github-project-automation bot moved this from Code Review / QA to Done in Waku Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weboko weboko

Labels
enhancement New feature or request
Projects
Waku
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add cross peer dependency for @waku packages waku-org/js-waku
1 participant
@weboko