Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for yt-dlp as a media downloader option #411

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

folliehiyuki
Copy link
Contributor

Description

This PR adds yt-dlp as another option for media downloader.

yt-dlp is a fork of youtube-dl, which is, in a lot of cases, preferred over youtube-dl. Since they are mostly compatible, I opt to reuse the viaYoutubeDL() function.

Checklist

@welcome
Copy link

welcome bot commented Aug 19, 2023

Thanks for opening this pull request!. We should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@folliehiyuki
Copy link
Contributor Author

A few reasons why we should support yt-dlp:

  • Quite a few applications support both, and use yt-dlp by default, e.g. gallery-dl, mpv
  • Lots of commits from youtube-dl are back-ported from yt-dlp, showing it's kind of behind in terms of development.
  • Some Linux distributions don't ship youtube-dl anymore, due to the lack of releases since 2021, e.g. AlpineLinux.

Copy link

It has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days

@waybackarchiver
Copy link
Contributor

@folliehiyuki Thanks for your work! Could you please merge the main branch?

@folliehiyuki
Copy link
Contributor Author

Could you please merge the main branch?

Done. The PR was rebased on the main branch.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 23.52941% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 44.56%. Comparing base (30dc536) to head (43ac6f6).

Files Patch % Lines
reduxer/media.go 23.52% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
- Coverage   44.59%   44.56%   -0.03%     
==========================================
  Files          84       84              
  Lines        6779     6792      +13     
==========================================
+ Hits         3023     3027       +4     
- Misses       3464     3473       +9     
  Partials      292      292              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waybackarchiver waybackarchiver merged commit d603da5 into wabarc:main Mar 1, 2024
77 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants