Wiki Reorg: Unify Param Page #6099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Redirect works on staging. |
filippoweb3
added
A2 - Please Review
DrW3RK
approved these changes
Jul 25, 2024
|
Looks good. I have not checked the render though. @CrackTheCode016 Could you cross check this? Can merge after Bader's approval. |
CrackTheCode016
requested changes
Jul 25, 2024
There was a problem hiding this comment.
Looks great! One thing - the "Accounts, Identity and Crowdloans" needs a tabbed setup like the others. It renders fine on my end after running locally.
Also - there was a merge conflict, I believe it's fine now, would be good to test on staging before merge just to be sure.
|
@CrackTheCode016 the "Accounts, Identity and Crowdloans" part has conditional rendering. I added the tabs only for tables where the conditional rendering does not work. Will add tabs later on when we remove the conditional rendering :) |
|
staging tested, all good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put Kusama info into the Polkadot page in the maintain section.
Mostly migrating content and removing Council and Tech Committee info. Further factual incorrect things can be addressed in a following PR.