Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RFC Approval Flow: Write-up -> Final Implementation #5585

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

filippoweb3
Copy link
Contributor

No description provided.

@filippoweb3 filippoweb3 added the A1 - In Progress Not ready for review yet. label Feb 7, 2024
@filippoweb3 filippoweb3 self-assigned this Feb 7, 2024
@filippoweb3 filippoweb3 requested a review from DrW3RK February 7, 2024 13:39
@filippoweb3 filippoweb3 added A2 - Please Review Pull request is ready for review. and removed A1 - In Progress Not ready for review yet. labels Feb 7, 2024
Copy link
Member

@DrW3RK DrW3RK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the page is titled "Building on Polkadot" which is different from "Building Polkadot", I have moved the Polkadot SDK section to the front.

I think I missed this during my earlier review of this page - RFC stands for Request for Comment, not Commit. Made the necessary changes through out the doc. Moved this section after Polkadot SDK, to show that the protocol is flexible to change itself if required.

Also refined the instructions originally added by @filippoweb3 in this PR.

Please review the newly added content and let me know if anything needs to be updated.

@DrW3RK
Copy link
Member

DrW3RK commented Feb 8, 2024

Also added a note that although the Fellowship maintains the runtime for Polkadot, they do not gate it completely. Anyone can set the runtime of Polkadot through an OpenGov referendum on root track.

@filippoweb3
Copy link
Contributor Author

@DrW3RK, thanks for the review and corrections. I added a couple of links to pages and some minor edits.

@filippoweb3 filippoweb3 merged commit 6189a9d into master Feb 8, 2024
2 checks passed
@filippoweb3 filippoweb3 deleted the edits-RFC branch February 8, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants