Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2P State Channels Milestone 2 #1224

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lukastanisic99
Copy link
Contributor

@lukastanisic99 lukastanisic99 commented Nov 13, 2024

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2350

@lukastanisic99
Copy link
Contributor Author

Just submitting officially for milestone 2 - I've added the article to be evaluated here as advised by @semuelle - Will be published on medium when we need to coordinate the announcement.

@PieWol
Copy link
Member

PieWol commented Nov 14, 2024

Hey @lukastanisic99 ,
thanks for your submission. please fix the application PR link in this PR description. :)

@lukastanisic99
Copy link
Contributor Author

@PieWol done 😁

@PieWol PieWol self-assigned this Nov 16, 2024
@PieWol
Copy link
Member

PieWol commented Nov 22, 2024

Hey @lukastanisic99
sorry for the delay, we have a lot going on at the moment. I will start evaluating this delivery on monday. Hope that works for you.

@lukastanisic99
Copy link
Contributor Author

Sure - it's the same state of the repository as the first milestone which you evaluated (just referencing different files) - it's submitted a few days later since we were waiting for feedback on the article, but seems the feedback will be part of this evaluation 🙂

@PieWol
Copy link
Member

PieWol commented Nov 25, 2024

Hey @lukastanisic99 ,
what's the testing guide for this milestone?

@lukastanisic99
Copy link
Contributor Author

Hey @PieWol it's the same testing guide since it's the same state of the repository (we didn't really look at it as milestone 1,milestone 2 when designing - was more for accounting purposes) but the integration tests are relevant - think I explained the reasoning in the guide

@PieWol
Copy link
Member

PieWol commented Nov 25, 2024

Alright. @lukastanisic99 I have created a PR for the evaluation.

#1229

There are only a few points I raised and I would appreciate it if you could improve these. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants