-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P2P State Channels Milestone 2 #1224
base: master
Are you sure you want to change the base?
Conversation
Just submitting officially for milestone 2 - I've added the article to be evaluated here as advised by @semuelle - Will be published on medium when we need to coordinate the announcement. |
Hey @lukastanisic99 , |
@PieWol done 😁 |
Hey @lukastanisic99 |
Sure - it's the same state of the repository as the first milestone which you evaluated (just referencing different files) - it's submitted a few days later since we were waiting for feedback on the article, but seems the feedback will be part of this evaluation 🙂 |
Hey @lukastanisic99 , |
Hey @PieWol it's the same testing guide since it's the same state of the repository (we didn't really look at it as milestone 1,milestone 2 when designing - was more for accounting purposes) but the integration tests are relevant - think I explained the reasoning in the guide |
Alright. @lukastanisic99 I have created a PR for the evaluation. There are only a few points I raised and I would appreciate it if you could improve these. Thanks. |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#2350