Relax Polling Rate of Status Page #2866
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ironoa
reviewed
Apr 15, 2024
ironoa
requested changes
Apr 16, 2024
Updated to be a |
ironoa
requested changes
May 14, 2024
| @@ -66,17 +67,17 @@ const App = () => { | |||
| })), | |||
| ); | |||
| setHasError(false); | |||
| setRefreshInterval(800); // Reset to faster refresh rate on success | |||
| setRefreshInterval(5000); // Reset to faster refresh rate on success | |||
There was a problem hiding this comment.
hardcoded value here ?
Comment says "faster", but 5000 is the same value of the REFRESH_INTERVAL constant, which seems to be used for the "Slow down" scenario...
=> maybe we need REFRESH_INTERVAL_FAST and REFRESH_INTERVAL_SLOW ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases time between endpoint queries
should resolve timeouts mentioned in https://github.com/w3f/1k-validators-be-PRIVATE/issues/50