Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add input.SetFiles #514

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Add input.SetFiles #514

merged 3 commits into from
Jan 12, 2024

Conversation

jrandolf-2
Copy link
Contributor

@jrandolf-2 jrandolf-2 commented Aug 22, 2023 •
edited by pr-preview bot
Loading

Issue #494

File dialog PR: #568

Preview | Diff

@jrandolf-2 jrandolf-2 assigned OrKoN and unassigned OrKoN Aug 22, 2023
OrKoN
OrKoN reviewed Aug 23, 2023
View reviewed changes
index.bs Outdated Show resolved Hide resolved
OrKoN
OrKoN reviewed Aug 23, 2023
View reviewed changes
index.bs Outdated Show resolved Hide resolved
@OrKoN
Copy link
Contributor

OrKoN commented Aug 25, 2023

@jgraham @whimboo @juliandescottes PTAL Perhaps you have suggestions for the open discussions and some other suggestions.

@jrandolf-2 jrandolf-2 force-pushed the jrandolf/set-files branch 4 times, most recently from 6b6ea1b to 22e6df6 Compare September 11, 2023 13:40
@css-meeting-bot css-meeting-bot mentioned this pull request Sep 14, 2023
Open
@jrandolf-2 jrandolf-2 force-pushed the jrandolf/set-files branch 4 times, most recently from 241213b to 4c827b8 Compare October 10, 2023 21:15
@jrandolf-2 jrandolf-2 requested a review from OrKoN October 10, 2023 21:15
@jrandolf-2 jrandolf-2 changed the base branch from main to jrandolf/file-dialog-opened October 11, 2023 08:31
@OrKoN OrKoN mentioned this pull request Oct 30, 2023
Open
OrKoN
OrKoN reviewed Nov 8, 2023
View reviewed changes
index.bs Outdated Show resolved Hide resolved
OrKoN
OrKoN reviewed Nov 8, 2023
View reviewed changes
index.bs Outdated Show resolved Hide resolved
OrKoN
OrKoN reviewed Nov 8, 2023
View reviewed changes
index.bs Outdated Show resolved Hide resolved
jgraham
jgraham reviewed Nov 8, 2023
View reviewed changes
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
OrKoN
OrKoN reviewed Nov 8, 2023
View reviewed changes
index.bs Outdated Show resolved Hide resolved
@jrandolf-2 jrandolf-2 force-pushed the jrandolf/set-files branch 3 times, most recently from e24c9dc to f350765 Compare November 8, 2023 12:03
@jrandolf-2 jrandolf-2 force-pushed the jrandolf/set-files branch 2 times, most recently from 8c5f652 to 921398a Compare November 8, 2023 14:17
@OrKoN OrKoN force-pushed the jrandolf/file-dialog-opened branch 2 times, most recently from 5421b69 to 4e766f5 Compare November 21, 2023 14:00
@whimboo
Copy link
Contributor

whimboo commented Jan 5, 2024

Looks like this PR stalled a bit. @jrandolf mind giving a quick update what's the status?

@jrandolf-2
Copy link
Contributor Author

@whimboo Waiting on File dialog PR: #568

@jrandolf-2 jrandolf-2 changed the base branch from jrandolf/file-dialog-opened to main January 8, 2024 12:54
whimboo
whimboo reviewed Jan 8, 2024
View reviewed changes
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
@jrandolf-2 @OrKoN
Update index.bs
1bb5bd8 
Co-authored-by: Alex Rudenko <[email protected]>
@jrandolf-2 jrandolf-2 force-pushed the jrandolf/set-files branch 3 times, most recently from d47c6c8 to 326b073 Compare January 10, 2024 18:27
whimboo
whimboo reviewed Jan 11, 2024
View reviewed changes
index.bs Outdated Show resolved Hide resolved
@jrandolf-2 @whimboo
Update index.bs
69ffc1a 
Co-authored-by: Henrik Skupin <[email protected]>
whimboo
whimboo approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. For me it looks fine. @jgraham can you please take a final look as well?

jgraham
jgraham reviewed Jan 12, 2024
View reviewed changes
index.bs Outdated Show resolved Hide resolved
@whimboo @jgraham
Update index.bs
337fe1f 
Co-authored-by: jgraham <[email protected]>
@whimboo
Copy link
Contributor

whimboo commented Jan 12, 2024

@jrandolf are you planning to write necessary wpt tests for this new feature?

@whimboo whimboo merged commit 804e6aa into main Jan 12, 2024
5 checks passed
@whimboo whimboo deleted the jrandolf/set-files branch January 12, 2024 13:43
github-actions bot added a commit that referenced this pull request Jan 12, 2024
@jrandolf-2 @github-actions
Add input.setFiles (#514)
c8ddb5d 
SHA: 804e6aa
Reason: push, by whimboo

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@OrKoN OrKoN mentioned this pull request Jan 15, 2024
Open
@jrandolf-2 jrandolf-2 mentioned this pull request Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrKoN OrKoN OrKoN approved these changes

@jgraham jgraham jgraham approved these changes

@whimboo whimboo whimboo approved these changes

@sadym-chromium sadym-chromium Awaiting requested review from sadym-chromium

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrandolf-2 @OrKoN @whimboo @jgraham