Fix AuthenticationExtensionsAuthenticatorInputs/Outputs CDDL #2219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the CDDL grammar, after a control operator (called
ctlop
in the grammar), there can only be atype2
production. In atype2
production, wrapping parentheses can only be used to wrap atype
production.tstr => any
is agroup
production. As such, unless I missed something, it cannot be wrapped in parentheses to produce atype2
production. It rather needs to be wrapped in curly braces or brackets.In other words, from a CDDL grammar perspective, this is an invalid type:
This is a valid type:
This update fixes the CDDL type definitions that used the
.within
operator with an invalid type2.I don't believe the change introduces any semantic change (so more an editorial update than anything else) but note I'm no CDDL expert, I just happened to have been playing with the CDDL grammar recently... If the semantics change, well, the problem still stands: the current definition is not valid CDDL.
Preview | Diff