Fix CDDL inconsistencies in attStmtType and compound format #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think the expression `attStmtTemplate .within $$attStmtType` successfully encodes the intent "Every attestation statement format must have the above fields", for two reasons: it does not define a CDDL rule since it contains no = sign, and even if it did, the `.within` control operator would apply only to the new type defined by that rule, but not to the `attObj` type. CDDL generally makes a distinction between types and groups, and only mentions control operators applying to types, so I don't think we can apply `.within` to `$$attStmtType` directly. This is why we need to duplicate the `authData` field in `attStmtTemplate`.
This is required by the new "compound" attestation statement format.
[CDDL][1] defines that:
>A map matches a specification given as a group when the group matches
>a sequence of name/value pairs such that all of these name/value
>pairs are present in the map and the map has no name/value pair that
>is not covered by the group.
Therefore the control `.within { fmt: text .ne "compound" }` forbids any maps
that contain additional fields besides `fmt`, which is clearly not what was
intended.
[1]: https://datatracker.ietf.org/doc/html/rfc8610#section-2.1
emlun
requested review from
MasterKale,
timcappalli,
selfissued and
akshayku
emlun
changed the title
MasterKale
approved these changes
Dec 5, 2024
github-actions bot
added a commit
that referenced
this pull request
Dec 11, 2024
SHA: 3bc8301 Reason: push, by agl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2210. Also fixes a couple of other issues I noticed while working on this:
$attStmtFormatthat (no longer?) exists, it should be$$attStmtType..within { fmt: text .ne "compound" }control onnonCompoundAttStmtinadvertently makesnonCompoundAttStmtunable to match anything, because maps are matched exhaustively (see CDDL, so the right-hand-side of.withinforbids additional fields beyondfmt.Preview | Diff