Store/update credential record last in RP ops #2215
Conversation
| the [=[RP]=] SHOULD fail the [=registration ceremony=]. | ||
| 1. If all the above steps are successful, | ||
| store |credentialRecord| in the [=user account=] that was denoted in <code>|pkOptions|.{{PublicKeyCredentialCreationOptions/user}}</code> | ||
| and continue the [=registration ceremony=] as appropriate. |
There was a problem hiding this comment.
What does "continue the registration ceremony" mean? The way I interpret that is that RPs may have specific criteria in addition to what's stated in the spec, and this line means for the RP to continue with said criteria. However if that is true, then it's possible the ceremony fails; but we already stated to store the credentialRecord. If my interpretation is correct, then this needs to be re-worded like:
If all the above steps are successful, continue the registration ceremony as appropriate. If the ceremony is successful, then store credentialRecord …
Ditto for the authentication ceremony section.
In other words the last "portion"/clause of the last sentence of the last step should be about storing/updating the credential unless subsequent clauses or sentences do not describe processes that even have the possibility for causing the ceremony to fail.
|
2024-11-27: @emlun to resolve @zacknewman's comments, then OK to merge. |
timcappalli
requested review from
timcappalli
and removed request for
MasterKale
SHA: 08d33dc Reason: push, by agl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Closes #2204.
Preview | Diff