Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect reference in Add Virtual Authenticator #2001

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

emlun
Copy link
Member

@emlun emlun commented Nov 22, 2023

§11.3. Add Virtual Authenticator currently reads:

[...]
3. For each enumerable own property in parameters:

  1. Let key be the name of the property.
  2. Let value be the result of getting a property named key from parameters.
  3. If there is no matching key for key in parameters, return a WebDriver error with WebDriver error code invalid argument.
  4. If value is not one of the valid values for that key, return a WebDriver error with WebDriver error code invalid argument.
  5. Set a property key to value on authenticator.
    [...]

The third step seems like it was intended to instead refer to Authenticator Configuration as the set of valid keys:

  1. If there is no matching key for key in Authenticator Configuration, return a WebDriver error with WebDriver error code invalid argument.

The subsequent step 5 checks that all properties of Authenticator Configuration are defined in parameters, so it seems it would make sense that step 3.3 would perform the opposite check, which would make the combination of both a set equality check rather than just a subset check.

@nsatragno Is the above assessment accurate?


Preview | Diff

@emlun emlun requested a review from nsatragno November 22, 2023 11:37
Copy link
Member

@nsatragno nsatragno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, your assessment is correct, good catch! Approved.

@emlun emlun changed the title Fix incorrect (?) reference in Add Virtual Authenticator Fix incorrect reference in Add Virtual Authenticator Nov 23, 2023
@timcappalli timcappalli self-requested a review November 29, 2023 20:14
@nadalin nadalin requested a review from pascoej November 29, 2023 20:14
@nadalin nadalin added this to the L3-WD-02 milestone Dec 13, 2023
@emlun emlun merged commit 2745802 into main Dec 13, 2023
2 checks passed
@emlun emlun deleted the fix-add-virtual-authenticator-typo branch December 13, 2023 20:13
github-actions bot added a commit that referenced this pull request Dec 13, 2023
SHA: 2745802
Reason: push, by emlun

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants