Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace start/stop with scan/AbortController #300

Merged
merged 2 commits into from
Aug 21, 2019
Merged

Replace start/stop with scan/AbortController #300

merged 2 commits into from
Aug 21, 2019

Conversation

beaufortfrancois
Copy link
Collaborator

@beaufortfrancois beaufortfrancois commented Aug 19, 2019 •
edited by pr-preview bot
Loading

This is a first draft to see if I'm heading in the right direction.
Let me know what you think.

Fix #225

Preview | Diff

kenchris
kenchris reviewed Aug 19, 2019
View reviewed changes
Copy link
Contributor

@kenchris kenchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is the AbortError event dispatched? Shouldn't it be?

index.html Show resolved Hide resolved
@beaufortfrancois
Copy link
Collaborator Author

@kenchris I thought it was done automatically like Push in the "add the following abort steps". Nope?

@kenchris
Copy link
Contributor

Ah maybe it is... If you could verify that would be great

@zolkis
Copy link
Contributor

zolkis commented Aug 21, 2019

Looks good.

@beaufortfrancois
Copy link
Collaborator Author

According to https://dom.spec.whatwg.org/#abortsignal-abort-algorithms,

An AbortSignal object has associated abort algorithms, which is a set of algorithms which are to be executed when its aborted flag is set.

To signal abort, given a AbortSignal object signal, run these steps:

  1. If signal’s aborted flag is set, then return.
  2. Set signal’s aborted flag.
  3. For each algorithm in signal’s abort algorithms: run algorithm.
  4. Empty signal’s abort algorithms.
  5. Fire an event named abort at signal.

@beaufortfrancois beaufortfrancois marked this pull request as ready for review August 21, 2019 10:00
@kenchris kenchris merged commit 1de4000 into w3c:gh-pages Aug 21, 2019
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 27, 2019
@chromium-wpt-export-bot
[webnfc] Use AbortController for NFCReader
02f4d58 
This CL uses AbortController to replace the stop() method of NFCReader
interface.

The corresponding spec change is from:
w3c/web-nfc#300

BUG=520391

Change-Id: Ia28bfb283a7ad66fb9c4cb0fc744582671a62fa0
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Aug 27, 2019
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 28, 2019
@chromium-wpt-export-bot
[webnfc] Use AbortController for NFCReader
2121613 
This CL uses AbortController to replace the stop() method of NFCReader
interface.

The corresponding spec change is from:
w3c/web-nfc#300

BUG=520391

Change-Id: Ia28bfb283a7ad66fb9c4cb0fc744582671a62fa0
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 29, 2019
@chromium-wpt-export-bot
[webnfc] Use AbortController for NFCReader
82ad418 
This CL uses AbortController to replace the stop() method of NFCReader
interface.

The corresponding spec change is from:
w3c/web-nfc#300

BUG=520391

Change-Id: Ia28bfb283a7ad66fb9c4cb0fc744582671a62fa0
aarongable pushed a commit to chromium/chromium that referenced this pull request Aug 30, 2019
[webnfc] Use AbortController for NFCReader
919b7ce 
This CL uses AbortController to replace the stop() method of NFCReader
interface.

The corresponding spec change is from:
w3c/web-nfc#300

BUG=520391

Change-Id: Ia28bfb283a7ad66fb9c4cb0fc744582671a62fa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769245
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: Rijubrata Bhaumik <[email protected]>
Commit-Queue: Leon Han <[email protected]>
Cr-Commit-Position: refs/heads/master@{#691988}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 30, 2019
@chromium-wpt-export-bot
[webnfc] Use AbortController for NFCReader
6864dbe 
This CL uses AbortController to replace the stop() method of NFCReader
interface.

The corresponding spec change is from:
w3c/web-nfc#300

BUG=520391

Change-Id: Ia28bfb283a7ad66fb9c4cb0fc744582671a62fa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769245
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: Rijubrata Bhaumik <[email protected]>
Commit-Queue: Leon Han <[email protected]>
Cr-Commit-Position: refs/heads/master@{#691988}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 30, 2019
@chromium-wpt-export-bot
[webnfc] Use AbortController for NFCReader
fb898b4 
This CL uses AbortController to replace the stop() method of NFCReader
interface.

The corresponding spec change is from:
w3c/web-nfc#300

BUG=520391

Change-Id: Ia28bfb283a7ad66fb9c4cb0fc744582671a62fa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769245
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: Rijubrata Bhaumik <[email protected]>
Commit-Queue: Leon Han <[email protected]>
Cr-Commit-Position: refs/heads/master@{#691988}
@beaufortfrancois beaufortfrancois deleted the scan-abort branch September 3, 2019 06:29
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 3, 2019
@moz-wptsync-bot
Bug 1576840 [wpt PR 18689] - [webnfc] Use AbortController for NFCRead…
dd3e4b2 
…er, a=testonly

Automatic update from web-platform-tests
[webnfc] Use AbortController for NFCReader

This CL uses AbortController to replace the stop() method of NFCReader
interface.

The corresponding spec change is from:
w3c/web-nfc#300

BUG=520391

Change-Id: Ia28bfb283a7ad66fb9c4cb0fc744582671a62fa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769245
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: Rijubrata Bhaumik <[email protected]>
Commit-Queue: Leon Han <[email protected]>
Cr-Commit-Position: refs/heads/master@{#691988}

--

wpt-commits: fb898b46adaf656c9807ed0b8adb39d84162cb98
wpt-pr: 18689
dbaron pushed a commit to dbaron/gecko that referenced this pull request Sep 4, 2019
@moz-wptsync-bot
Bug 1576840 [wpt PR 18689] - [webnfc] Use AbortController for NFCRead…
a362bde 
…er, a=testonly

Automatic update from web-platform-tests
[webnfc] Use AbortController for NFCReader

This CL uses AbortController to replace the stop() method of NFCReader
interface.

The corresponding spec change is from:
w3c/web-nfc#300

BUG=520391

Change-Id: Ia28bfb283a7ad66fb9c4cb0fc744582671a62fa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769245
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: Rijubrata Bhaumik <[email protected]>
Commit-Queue: Leon Han <[email protected]>
Cr-Commit-Position: refs/heads/master@{#691988}

--

wpt-commits: fb898b46adaf656c9807ed0b8adb39d84162cb98
wpt-pr: 18689
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1576840 [wpt PR 18689] - [webnfc] Use AbortController for NFCRead…
1060f41 
…er, a=testonly

Automatic update from web-platform-tests
[webnfc] Use AbortController for NFCReader

This CL uses AbortController to replace the stop() method of NFCReader
interface.

The corresponding spec change is from:
w3c/web-nfc#300

BUG=520391

Change-Id: Ia28bfb283a7ad66fb9c4cb0fc744582671a62fa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769245
Reviewed-by: Daniel Cheng <dchengchromium.org>
Reviewed-by: Reilly Grant <reillygchromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumikintel.com>
Commit-Queue: Leon Han <leon.hanintel.com>
Cr-Commit-Position: refs/heads/master{#691988}

--

wpt-commits: fb898b46adaf656c9807ed0b8adb39d84162cb98
wpt-pr: 18689

UltraBlame original commit: fad16189ee2b34bbc164f69971e44c04d5eb1018
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1576840 [wpt PR 18689] - [webnfc] Use AbortController for NFCRead…
0f999b2 
…er, a=testonly

Automatic update from web-platform-tests
[webnfc] Use AbortController for NFCReader

This CL uses AbortController to replace the stop() method of NFCReader
interface.

The corresponding spec change is from:
w3c/web-nfc#300

BUG=520391

Change-Id: Ia28bfb283a7ad66fb9c4cb0fc744582671a62fa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769245
Reviewed-by: Daniel Cheng <dchengchromium.org>
Reviewed-by: Reilly Grant <reillygchromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumikintel.com>
Commit-Queue: Leon Han <leon.hanintel.com>
Cr-Commit-Position: refs/heads/master{#691988}

--

wpt-commits: fb898b46adaf656c9807ed0b8adb39d84162cb98
wpt-pr: 18689

UltraBlame original commit: fad16189ee2b34bbc164f69971e44c04d5eb1018
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
@marco-c
Bug 1576840 [wpt PR 18689] - [webnfc] Use AbortController for NFCRead…
0dbef38 
…er, a=testonly

Automatic update from web-platform-tests
[webnfc] Use AbortController for NFCReader

This CL uses AbortController to replace the stop() method of NFCReader
interface.

The corresponding spec change is from:
w3c/web-nfc#300

BUG=520391

Change-Id: Ia28bfb283a7ad66fb9c4cb0fc744582671a62fa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769245
Reviewed-by: Daniel Cheng <dchengchromium.org>
Reviewed-by: Reilly Grant <reillygchromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumikintel.com>
Commit-Queue: Leon Han <leon.hanintel.com>
Cr-Commit-Position: refs/heads/master{#691988}

--

wpt-commits: fb898b46adaf656c9807ed0b8adb39d84162cb98
wpt-pr: 18689

UltraBlame original commit: fad16189ee2b34bbc164f69971e44c04d5eb1018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenchris kenchris kenchris left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider using AbortController rather than a stop() method
3 participants
@beaufortfrancois @kenchris @zolkis