Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4.6-headings-and-labels-descriptive-icons #4147

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

detlevhfischer
Copy link
Contributor

@detlevhfischer detlevhfischer commented Nov 21, 2024

A proposed addition to the 2.4.6 Understanding text that states that conventional icons can in some cases serve as descriptive label of form controls. Included is an example of a conventional icon (loupe for search).

See rendered version of the revised 2.4.6 Understanding text (updated 26 Nov 2024)

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for wcag2 failed.

Name Link
🔨 Latest commit a9e2ef7
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/6745c4daaf8d5a00087fcd8e

Wording changes to explanation of descriptive icon (different contexts affext interpretation).
minor wording changes
Changing "loupe" to "magnifying glass"
understanding/20/headings-and-labels.html Outdated Show resolved Hide resolved
understanding/20/headings-and-labels.html Outdated Show resolved Hide resolved
understanding/20/headings-and-labels.html Outdated Show resolved Hide resolved
@detlevhfischer
Copy link
Contributor Author

detlevhfischer commented Nov 21, 2024

Sounds all very reasonable. Do you want to create a PR on my PR or do you want me to implement those changes?

@scottaohara
Copy link
Member

@detlevhfischer i provided them as suggestions so that if you agree with them, you can just commit them into your existing PR via GitHub's "commit suggestion" button that follows each of my proposed changes.

I would rather you be the one to commit these, as personally am against the idea of someone editing/committing to someone else's PR without explicit permission :)

@detlevhfischer
Copy link
Contributor Author

@scottaohara

as personally am against the idea of someone editing/committing to someone else's PR without explicit permission :)

I gave you permission, I suggested it :) - but no problem, I think your suggestions are good and I will work them in myself.

@patrickhlauke
Copy link
Member

patrickhlauke commented Nov 22, 2024

@detlevhfischer

I will work them in myself

just to reiterate, if it's not obvious: all you need to do is press the "Commit suggestion" for each here in github, no need to manually try to rework your PR

screenshot of one of scott's suggestions, with a red arrow pointing to the 'Commit suggestion' button below it in the github interface

detlevhfischer and others added 4 commits November 26, 2024 13:50
magnify glass -> magnifying glass
(assuming this is the more common term?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants