-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.4.6-headings-and-labels-descriptive-icons #4147
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for wcag2 failed.
|
Wording changes to explanation of descriptive icon (different contexts affext interpretation).
minor edit.
minor wording changes
Changing "loupe" to "magnifying glass"
Sounds all very reasonable. Do you want to create a PR on my PR or do you want me to implement those changes? |
@detlevhfischer i provided them as suggestions so that if you agree with them, you can just commit them into your existing PR via GitHub's "commit suggestion" button that follows each of my proposed changes. I would rather you be the one to commit these, as personally am against the idea of someone editing/committing to someone else's PR without explicit permission :) |
I gave you permission, I suggested it :) - but no problem, I think your suggestions are good and I will work them in myself. |
just to reiterate, if it's not obvious: all you need to do is press the "Commit suggestion" for each here in github, no need to manually try to rework your PR |
Co-authored-by: Scott O'Hara <[email protected]>
Co-authored-by: Scott O'Hara <[email protected]>
Co-authored-by: Scott O'Hara <[email protected]>
magnify glass -> magnifying glass (assuming this is the more common term?)
A proposed addition to the 2.4.6 Understanding text that states that conventional icons can in some cases serve as descriptive label of form controls. Included is an example of a conventional icon (loupe for search).
See rendered version of the revised 2.4.6 Understanding text (updated 26 Nov 2024)