Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update C43 to add test case for Focus Not Obscured Enhanced #3534

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

fstrr
Copy link
Contributor

@fstrr fstrr commented Nov 3, 2023

Closes #3532

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit f24d1df
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/66db19001fb5880008b9a971
😎 Deploy Preview https://deploy-preview-3534--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bruce-usab
Copy link
Contributor

Discussed on backlog call 9/6.

@detlevhfischer
Copy link
Contributor

detlevhfischer commented Sep 16, 2024

Why is it that the Deploy Preview links always seem to be broken? Having a link to a clean preview would simplify the review.

@patrickhlauke
Copy link
Member

@detlevhfischer the deploy links need to be manually expanded to include the actual file you're trying to look at (the deploy preview has no root/index). so in this case, the deploy preview is https://deploy-preview-3534--wcag2.netlify.app/, the file changed here is techniques/css/C43.html, so you want to manually go to https://deploy-preview-3534--wcag2.netlify.app/techniques/css/c43

(with hat tip to @kfranqueiro for pointing that out to me recently)

It would of course be super helpful if the deploy preview had some form of initial index (even if just a throwaway page that points to /techniques/ and /understanding/

@alastc alastc merged commit f34966e into main Oct 9, 2024
5 checks passed
@alastc alastc deleted the fstrr-patch-3 branch October 9, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants