-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/Adjust the searchbar to perform searches by title, description or context #238
Merged
nomadbitcoin
merged 5 commits into
w3b3d3v:feat/web3task-staging
from
Hardsys-Andre:feat/searchBar
Sep 26, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ccdadb6
feat/Adjust the searchbar to perform searches by title, description o…
Hardsys-Andre 19bb212
fix/ removal of the translation function in IssueCard (t={t}) and red…
Hardsys-Andre e9fea0b
fix-adjustment in filter and search mode within issues and translatio…
Hardsys-Andre c0d54a6
naming adjustment in filterIssuesBySearchAndFilters
Hardsys-Andre 3de5a0b
Delete yarn.lock
nomadbitcoin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,10 +98,10 @@ Deploy this project on Vercel in one click: | |
|
||
#### Windows | ||
|
||
1. Download and install Java from the official [Oracle website](https://www.java.com/en/download/ie_manual.jsp). Make sure to choose the version suitable for your system. | ||
1. Download and install SDK Java 20 from the official [Oracle website](https://www.oracle.com/java/technologies/javase/jdk20-archive-downloads.html). Make sure to choose the version suitable for your system. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice! |
||
2. Open Command Prompt and set the `JAVA_HOME` environment variable: | ||
```cmd | ||
set JAVA_HOME=C:\Program Files\Java\jdk-22 | ||
set JAVA_HOME=C:\Program Files\Java\jdk-20 | ||
``` | ||
3. Add Java to your `PATH`: | ||
```cmd | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,7 +31,7 @@ const TaskPage = ({ issues }) => { | |
filteredIssues, | ||
availableAmounts, | ||
getFilterComponentProps, | ||
} = useFilterState(issues) | ||
} = useFilterState(issues, searchQuery) | ||
|
||
useEffect(() => { | ||
const unsubscribe = onAuthStateChanged(auth, async (user) => { | ||
|
@@ -57,7 +57,11 @@ const TaskPage = ({ issues }) => { | |
</Head> | ||
<div className="flex w-full items-center justify-center"> | ||
<div className="flex w-full flex-col xl:w-[80%]"> | ||
<SearchBar searchQuery={searchQuery} setSearchQuery={setSearchQuery} /> | ||
<SearchBar | ||
searchQuery={searchQuery} | ||
setSearchQuery={setSearchQuery} | ||
placeholder={t('task.taskPlaceholder')} | ||
/> | ||
<div className="flex"> | ||
<div className="flex w-full flex-col items-start md:mx-4 lg:flex-row"> | ||
<Filter | ||
|
@@ -121,7 +125,7 @@ const TaskPage = ({ issues }) => { | |
</div> | ||
<div className="flex flex-col gap-4"> | ||
{filteredIssues.map((issue) => ( | ||
<IssueCard key={issue.github_id} issue={issue} t={t} userInfo={userAuth} /> | ||
<IssueCard key={issue.github_id} issue={issue} userInfo={userAuth} /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pass userAuth as parameter is very weird, avoid doing that since we can get this information globally |
||
))} | ||
</div> | ||
</div> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think search and filtering should be separate hooks that operate on the same data.