Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Simplify the jupyter plugin #170

Merged
merged 9 commits into from
Feb 26, 2024

Conversation

DanielSchiavini
Copy link
Collaborator

@DanielSchiavini DanielSchiavini commented Feb 21, 2024

This reverts commit 50ee8e9

What I did

  • Refactored a bit the code now that we have the tests in master

How I did it

  • By removing proxy functions from javascript and calling the rpc directly from python
  • Moved the BrowserRPC up in the file and injected it into the BrowserSigner so all calls go through it

How to verify it

  • Plugin should keep on working

Description for the changelog

N/A

Cute Animal Picture

image

* simplify tests for jupyter plugin
* Run jupyter tests separately with proper dependencies
@DanielSchiavini DanielSchiavini merged commit 89362ac into vyperlang:jupyter Feb 26, 2024
6 of 9 checks passed
@DanielSchiavini
Copy link
Collaborator Author

moved to #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants