Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gleefre/define start function #85

Closed
wants to merge 6 commits into from

Conversation

Gleefre
Copy link
Contributor

@Gleefre Gleefre commented Oct 20, 2023

Reopens #78. Also see #65 and #58.

I don't really like the API to be honest, so it is still a draft.

@Gleefre Gleefre force-pushed the gleefre/define-start-function branch 3 times, most recently from 490de0c to 3c08151 Compare October 20, 2023 19:21
@vydd
Copy link
Owner

vydd commented Oct 20, 2023

Hey @Gleefre,

I don't think I understand why define-start-function is better than make-executable. I get the logic behind adding options to define-start-function though, but it feels unnecessarily custom.

In my mind, we could have a general make-executable method that works across various distributions, and we could make it call additional methods when they are defined for setup / cleanup / etc (if we don't want to have users directly define before/after). So, something like

(defmethod before-export ((sketch foo))
  ...)

defmethod after-whatever ((sketch foo))
  ...)

(make-executable 'foo :out "foo.exe") ; let's imagine we are on Windows!

@Gleefre Gleefre force-pushed the gleefre/define-start-function branch from 3c08151 to 357aa30 Compare November 2, 2023 23:16
@Gleefre Gleefre force-pushed the gleefre/define-start-function branch from 357aa30 to 44e62fe Compare November 5, 2023 15:25
@Gleefre Gleefre closed this Nov 5, 2023
@Gleefre
Copy link
Contributor Author

Gleefre commented Nov 5, 2023

Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants