Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#35 Added an optional call-site id as an arg to spy and brk #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#35 Added an optional call-site id as an arg to spy and brk #36

wants to merge 1 commit into from

Conversation

npetryk
Copy link

@npetryk npetryk commented Mar 1, 2019

No description provided.

@npetryk
Copy link
Author

npetryk commented Mar 1, 2019

For issue #35

@npetryk npetryk force-pushed the named-call-sites branch from a794c26 to 832cb1c Compare March 3, 2019 05:02
@viebel
Copy link

viebel commented Sep 11, 2019

@vvvvalvalval @npetryk any progress on merging this (useful) PR?

@vvvvalvalval
Copy link
Owner

Sorry for the response delay. I have no problem with extending last-ep-id (feel free to propose a new power doing just that); however, it's not clear to me that user-supplied Code Site ids are desirable (I like the minimalism of them being just negative numbers; opening them to more than this could lead conflicts or validation issues). So not merging this right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npetryk @viebel @vvvvalvalval