Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetcher without viper #204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

flashpixx
Copy link

What did you implement:

Moving viper argument call for batch-size into commands so the Fetcher can be used as a library

Fixes #202

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Running fetcher command an tests

Checklist:

  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch-Size as property
1 participant