Ray Tracing Pipeline (KHR) #2564
Open
+3,356
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finally a working example with |
|
I have done the major changes and the PR should be ready for review. I will add some description in PR page and maybe some unit tests soon. |
ComfyFluffy
commented
Nov 27, 2024
| @@ -60,13 +61,13 @@ vulkan_enum! { | |||
| // TODO: document | |||
| Graphics = GRAPHICS, | |||
|
|
|||
| /* TODO: enable | |||
|
|
|||
| // TODO: document | |||
| RayTracing = RAY_TRACING_KHR | |||
| RequiresOneOf([ | |||
| RequiresAllOf([DeviceExtension(khr_ray_tracing_pipeline)]), | |||
| RequiresAllOf([DeviceExtension(nv_ray_tracing)]), | |||
There was a problem hiding this comment.
Should we leave only khr and remove nv?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation to reflect any user-facing changes - in this repository.
Make sure that the changes are covered by unit-tests.
Run
cargo clippyon the changes.Run
cargo +nightly fmton the changes.Please put changelog entries in the description of this Pull Request
if knowledge of this change could be valuable to users. No need to put the
entries to the changelog directly, they will be transferred to the changelog
file by maintainers right after the Pull Request merge.
Changelog:
Changes
RayTracingPipeline, which corresponds to thevkPipelineobject and construction methods and structs.bind_pipeline_ray_tracing&trace_rays(vkCmdTraceRaysKHR) in the old and new sync.Device::get_ray_tracing_shader_group_handles. Used in building the shader binding table.ShaderGroupHandlesData. Helper for the data fromget_ray_tracing_shader_group_handles.ShaderBindingTable. Struct that holds the addresses and underlying buffer of shader binding table, which is used intrace_rays. It contains a constructor that automatically build the SBT from pipeline groups.triangle-raytracing-autofor the oldAutoCommandBuffer, andtriangle-raytracingfor the newtaskgraphsync.Not implemented (yet) in this PR
DeferredOperationKHR. Not planned.RayTracingCaptureReplay. Not planned.RayTracingPipelineStackSize(in dynamic stats). Maybe in this PR?