Ray tracing shaders prep #1737
Draft
Ray tracing shaders prep #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor write entry point to later support raytracing class of execution models. KhronosGroup/SPIRV-Headers@0350b1d KhronosGroup/SPIRV-Headers@95b48ce
Rua
reviewed
Oct 24, 2021
| )}, | ||
| ) | ||
| } else { | ||
| if let ExecutionModel::Kernel = *execution { |
There was a problem hiding this comment.
match execution instead of many ifs would be clearer IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft note: this was done quickly, I will refine later. It seems to be missing the storage classes
This is a small subsection of #1350 which starts adding support for raytracing shaders to fit in an eventual raytracing pipeline.
It refactors entry point to later support raytracing class of models.
It also adds the device requirements for storage classes associated with raytracing.