Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve TypeScript type errors in .vitepress/config #2549

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

DDDDD12138
Copy link
Contributor

Before

There are some TypeScript type errors in the .vitepress/config directory :
image

Description

This PR addresses and resolves TypeScript type errors found in the .vitepress/config directory.
And the collapsable configuration has been removed in this vitepress PR, replaced by the new property collapsed, so I removed the unnecessary collapsable configuration.

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit 8d30252
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/673dc3db19717500082987b3
😎 Deploy Preview https://deploy-preview-2549--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Would you mind adding a check on Ci so we can catch these warnings in the future?
I suppose running tsc in the docs directory would catch this.

@DDDDD12138
Copy link
Contributor Author

Let me give it a try.

@DDDDD12138
Copy link
Contributor Author

Would you mind adding a check on Ci so we can catch these warnings in the future? I suppose running tsc in the docs directory would catch this.

I've added it. Considering that the theme/index.mts file imports .vue files, I used vue-tsc.

Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks

@cexbrayat cexbrayat merged commit c493cc7 into vuejs:main Nov 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants