Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: message section #81

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Feature: message section #81

merged 6 commits into from
Mar 27, 2024

Conversation

yamageji
Copy link
Contributor

issue

https://github.com/vuejs-jp/vuefes-2024-backside/issues/67

Details

トップページのメッセージセクションを実装しました。
Figma

確認事項

  • タイトルは他セクションに合わせて、VFTitleコンポーネントを使用していますが、デザインカンプとフォントサイズなどが異なっていそうでした。こちら一旦このままとしています。
  • メッセージは、現状デザインカンプのもの(2023のもの?)を入れています。

Copy link

netlify bot commented Mar 24, 2024

Deploy Preview for vuefes-2024 ready!

Name Link
🔨 Latest commit 0936862
🔍 Latest deploy log https://app.netlify.com/sites/vuefes-2024/deploys/6602d3dc2aeeb500081c4215
😎 Deploy Preview https://deploy-preview-81--vuefes-2024.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yamageji
Copy link
Contributor Author

yamageji commented Mar 26, 2024

@jiyuujin
メッセージを修正しました。
英訳はDeepLを使用し、ざっとだけ確認しています。
よろしくお願いします!

https://vuejs-jp.esa.io/posts/894

@yamageji yamageji requested a review from jiyuujin March 26, 2024 14:05
Copy link
Collaborator

@jiyuujin jiyuujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiyuujin jiyuujin merged commit 14f814a into main Mar 27, 2024
9 checks passed
@jiyuujin jiyuujin deleted the feature/message-page-section branch March 27, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants