faet: sponsor section #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rad-froyo-c5cd05 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jiyuujin
reviewed
Mar 23, 2024
| type: Boolean, | ||
| default: false, | ||
| }, | ||
| href: { |
There was a problem hiding this comment.
NITS
おそらく昨年やっていたことと記憶していますが、
コンポーネントごちゃとしますし、Button という名目でリンクを提供するのは違和感を感じるかも
jiyuujin
reviewed
Mar 23, 2024
| <MarkDownText path="sponsor" /> | ||
| </div> | ||
|
|
||
| <img class="sponsor-term" src="/sponsor/sponsor-term.svg" alt="スポンサー申込期間 2024.4.1(月)-2024.4.30(火)" width="344" |
There was a problem hiding this comment.
✍️
CSS ベタ書きではなく SVG 読込で対応されたんですね
jiyuujin
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sponsor section
Todo and Question
VFButton を試しにつくってみた