Feat/Add vue-tsc #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryuhei373
reviewed
Feb 11, 2024
|
npx nuxi typecheck があるので手動で vue-tsc の環境を用意しなくてもいいんじゃないかなと最初は思っていたんですが、ちょっと試してみた結果、現状では結局 vue-tsc と typescript を突っ込んでやらないといけなさそう（ https://nuxt.com/docs/guide/concepts/typescript#type-checking ）なので、 @kokoakuma さんの対応で問題ないと思いました！
大命題である型チェックの追加という部分に関してはLGTMです！ @jiyuujin @toshick |
toshick
approved these changes
Feb 12, 2024
to allow patch update according to the rule of definitelyTyped
|
@ryuhei373 @toshick @ryuhei373 |
|
LGTM！ |
ryuhei373
approved these changes
Feb 12, 2024
jiyuujin
reviewed
Feb 13, 2024
jiyuujin
requested changes
Feb 13, 2024
jiyuujin
reviewed
Feb 13, 2024
|
マージありがとうございます！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://github.com/vuejs-jp/vuefes-2024-backside/issues/29
Details
vue-tscの追加@types/nodeと@nuxt/typesの追加Others
相談事項
verbatimModuleSyntaxの取り扱いについて、この設定が後ほどどれくらい面倒になるのかあまりピンと来ておらず、以下のどれにするかアドバイスいただきたいです！
https://zenn.dev/teppeis/articles/2023-04-typescript-5_0-verbatim-module-syntax
import type { Foo } from ./Foo.tsのように書く現時点で問題がなさそうであれば、Trueにしてみるのもありなのかなと思っています。