Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/privacy page #46

Merged
merged 25 commits into from
Mar 23, 2024
Merged

Feature/privacy page #46

merged 25 commits into from
Mar 23, 2024

Conversation

kokoakuma
Copy link
Contributor

@kokoakuma kokoakuma commented Mar 14, 2024 •
edited
Loading

issue

https://github.com/vuejs-jp/vuefes-2024-backside/issues/71

Details

  • プライバシーポリシーページをデザインに沿って実装
  • ポリシーの文言はこちら
  • Figma

Todo

  • プライバシーポリシーのタイトルの英語版追加
  • Figmaコメントの返信を反映

Note

@kokoakuma kokoakuma self-assigned this Mar 14, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 14, 2024 •
edited
Loading

✅ Deploy Preview for rad-froyo-c5cd05 ready!

Name Link
🔨 Latest commit 41e4aa3
🔍 Latest deploy log https://app.netlify.com/sites/rad-froyo-c5cd05/deploys/65fed07c8009b80008bc9308
😎 Deploy Preview https://deploy-preview-46--rad-froyo-c5cd05.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kokoakuma
Copy link
Contributor Author

LinkButtonのstorybookが表示されない 😢

@kokoakuma kokoakuma changed the title WIP Feature/privacy page Feature/privacy page Mar 21, 2024
@kokoakuma kokoakuma requested review from toshick and jiyuujin March 21, 2024 15:53
@kokoakuma
Copy link
Contributor Author

@jiyuujin @toshick
デザインの質問中ですが、お手隙で確認お願いします！ 🙇

@kokoakuma kokoakuma requested a review from toshick March 23, 2024 10:20
@kokoakuma
Copy link
Contributor Author

@toshick コメント箇所の修正＆デザインの調整しました！ 🙇

jiyuujin
jiyuujin approved these changes Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@jiyuujin jiyuujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM です mm

@kokoakuma
Copy link
Contributor Author

マージします 🙇

@kokoakuma kokoakuma merged commit dcbc74e into main Mar 23, 2024
9 checks passed
@jiyuujin jiyuujin deleted the feature/privacy_page branch March 29, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@totocalcio totocalcio totocalcio left review comments

@jiyuujin jiyuujin jiyuujin approved these changes

@toshick toshick Awaiting requested review from toshick

Assignees

@kokoakuma kokoakuma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kokoakuma @toshick @jiyuujin @totocalcio