Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cypress #3

Merged
merged 9 commits into from
Feb 10, 2024
Merged

Feat/cypress #3

merged 9 commits into from
Feb 10, 2024

Conversation

toshick
Copy link
Contributor

@toshick toshick commented Feb 9, 2024

  • Cypressをインストールしました
    • apps/web/app/tests
  • READMEに方針を書いてみました

image

cd apps/web && bun cypress:open

image

@toshick toshick self-assigned this Feb 9, 2024
@jiyuujin
Copy link
Collaborator

jiyuujin commented Feb 9, 2024

apps/web/app/tests

度々ディレクトリ構成について指摘のほどすみません mm
Nuxt の srcDir である app 直下ではなく、nuxt.config.ts と同列の apps/web/tests に置き換えたいお気持ちです

@vuejs-jp/vuefes-2024-maintainer 他ご意見等あれば

@toshick
Copy link
Contributor Author

toshick commented Feb 10, 2024

image

Copy link
Collaborator

@jiyuujin jiyuujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nuxt の型定義のみ修正いただければ mm

@toshick
Copy link
Contributor Author

toshick commented Feb 10, 2024

tsconfigを修正しました

769363e

Copy link
Collaborator

@jiyuujin jiyuujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toshick toshick merged commit b1c5859 into main Feb 10, 2024
1 check passed
@jiyuujin jiyuujin deleted the feat/cypress branch April 19, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants