Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/open props #21

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Feat/open props #21

merged 4 commits into from
Mar 7, 2024

Conversation

toshick
Copy link
Contributor

@toshick toshick commented Mar 2, 2024

What

sample card

desktop mobile
image image

上書き戦略

  1. まずDesktop用のものを定義する
  2. タブレット以下(--tablet)で上書き(必要な分のみ)
    タブレットのみ、ではなくタブレット以下で上書きをするので、変更しなければわざわざモバイル用の指定をしなくてもよい
  3. 必要であればスマホ以下(--mobile)で上書き

マージンなど

--unitを利用して8の倍数で設定していく

  • calc(var(--unit) * 2) = 16px
  • calc(var(--unit) * 0.5) = 4px

Issue

https://github.com/orgs/vuejs-jp/projects/4/views/5?pane=issue&itemId=53182527
https://github.com/vuejs-jp/vuefes-2024-backside/issues/49

@toshick toshick self-assigned this Mar 2, 2024
Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for rad-froyo-c5cd05 ready!

Name Link
🔨 Latest commit 736523d
🔍 Latest deploy log https://app.netlify.com/sites/rad-froyo-c5cd05/deploys/65e9a3df3dcd230008941ed8
😎 Deploy Preview https://deploy-preview-21--rad-froyo-c5cd05.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@jiyuujin jiyuujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiyuujin jiyuujin merged commit 3fcda11 into main Mar 7, 2024
9 checks passed
@jiyuujin jiyuujin deleted the feat/open-props branch March 7, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants