Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/move button to component directory #19

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Conversation

kokoakuma
Copy link
Contributor

@kokoakuma kokoakuma commented Mar 2, 2024

issue

https://github.com/vuejs-jp/vuefes-2024-backside/issues/46

Details

component直下へ移動

一旦、直下で問題ないと思ったので移動しました!(量が多くなり視認性が悪くなった場合はその時に相談させてください 🙏 )
storiesファイルのtitleは階層あっても良さそうなので、 Forms/SubmitButtonのままにしてあります。

@kokoakuma kokoakuma self-assigned this Mar 2, 2024
Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for rad-froyo-c5cd05 ready!

Name Link
🔨 Latest commit df5447d
🔍 Latest deploy log https://app.netlify.com/sites/rad-froyo-c5cd05/deploys/65e2a9e8636f8f000871f983
😎 Deploy Preview https://deploy-preview-19--rad-froyo-c5cd05.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kokoakuma kokoakuma requested review from jiyuujin, toshick and ryuhei373 and removed request for jiyuujin and toshick March 2, 2024 04:30
@kokoakuma
Copy link
Contributor Author

とりあえずryuheiさんにレビュー依頼投げちゃったんですが、特に意図はないです! 🙇

Copy link
Collaborator

@jiyuujin jiyuujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kokoakuma kokoakuma merged commit ad07e9a into main Mar 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants