Feat/Add submit button #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rad-froyo-c5cd05 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
toshick
reviewed
Feb 25, 2024
| disabled?: boolean | ||
| } | ||
| interface SubmitButtonEmit { | ||
| (event: 'on-click'): void |
There was a problem hiding this comment.
イベントにonをつけると今後すべてのイベントにonをつけることになりそうです。
<SubmitButton @on-click="onClick">さぶみっと</SubmitButton>
@がすでにイベントなので自分は @click 等と書くのが通常です
<SubmitButton @click="onClick">さぶみっと</SubmitButton>
今後どちらかに統一していこうかと思います
There was a problem hiding this comment.
@toshick すみません、再レビュー依頼するのすっかり忘れてました！ 🙇
There was a problem hiding this comment.
やっぱり一旦マージしてしまいますね 🙇 （コメントいただいた場合は別PRで対応します！）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
https://github.com/vuejs-jp/vuefes-2024-backside/issues/46
Details
SubmitButtonとstoriesファイルの作成
Screenshots