Feat/Add LocaleSwitch component #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuefes-2024 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
totocalcio
requested review from
KannoStanfoot and
jiyuujin
and removed request for
KannoStanfoot
totocalcio
changed the title
toshick
reviewed
May 20, 2024
| return router.currentRoute.value.path.replace(`/${LANGUAGES.ENGLISH}`, '') | ||
| } | ||
| const setSwitchStatus = () => { | ||
| isChecked.value = router.currentRoute.value.path.includes(LANGUAGES.ENGLISH) |
There was a problem hiding this comment.
pathのなかに en があるだけでマッチしそうなので、 /en/ とかにしたほうがよいよーなきがします
たとえば /children とかでも 英語だと判断される？
There was a problem hiding this comment.
探索的に確認はしていないですが、トップページでhttps://vuefes.jp/2024/enとなるケースがないのであれば、確かに/en/の方が妥当だと思います。
説明にも書きましたが、トレイリングスラッシュの対応がされている場合は以下の処理を削除できます。
// トレイリングスラッシュ対策
if (path === '') {
router.push('/')
return
}
toshick
reviewed
May 20, 2024
Comment on lines
83
to
85
| * { | ||
| --box-shadow: 0 1px 4px color-mix(in srgb, var(--color-vue-blue), transparent calc(100% - 14%)); | ||
| } |
There was a problem hiding this comment.
全タグに対して変数宣言しているよーに見えますが、なにかこれが悪さしないかちょっとだけ心配です。
でも、動いていればとりあえずokです。
（もしくはこれが一般的な書き方？）
There was a problem hiding this comment.
scopedなのであくまで影響範囲はLocaleSwitchコンポーネント内のため、問題なしと判断しました。
一般的かどうかまでは調べきれていないので、コンポーネント全体への定義で他に一般的な使用方法があればそちらを検討したいです。（locale-switch-buttonへの定義でも構わない）
toshick
approved these changes
May 21, 2024
KannoStanfoot
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
https://github.com/vuejs-jp/vuefes-2024-backside/issues/158
Details of Changes
Others
Screenshots
※Adobe CC 未契約により、DIN 2014がインストールされていません。
スクリーンショットがデザインカンプと異なっているため、フォントお持ちの方ご確認お願い致します。