Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: form page section background #133

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

totocalcio
Copy link
Contributor

@totocalcio totocalcio commented Apr 30, 2024

issue

https://github.com/vuejs-jp/vuefes-2024-backside/issues/140

iOSで背景画像が正しく表示されない不具合の改修

原因

  • iOSでのみ発生する不具合
  • background-blend-modeはbackground-repeat:repeatなど、特定の状況下で機能しない。
  • バグレポート

作業内容

background-blend-modeではなく、mix-blend-modeで実装。

検証環境

  • Mac (macOS Sonoma 14.4.1) / Safari
  • Windows 11 / Chrome, Edge, Firefox
  • iPhone Xs Max (iOS 17.4.1) / Safari

確認事項

Androidが手元にないため、ご確認いただけると助かります。

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for vuefes-2024 ready!

Name Link
🔨 Latest commit 25f75c3
🔍 Latest deploy log https://app.netlify.com/sites/vuefes-2024/deploys/6630fdbea658450008e4a6ab
😎 Deploy Preview https://deploy-preview-133--vuefes-2024.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@totocalcio totocalcio requested a review from jiyuujin April 30, 2024 14:23
@totocalcio totocalcio changed the title Draft: fix: form page section background fix: form page section background Apr 30, 2024
Copy link
Collaborator

@jiyuujin jiyuujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiyuujin jiyuujin merged commit a5e33e6 into main May 1, 2024
11 checks passed
@jiyuujin jiyuujin deleted the fix/form-page-section-background branch May 1, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants