Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
driver-gekko.c
, the right side of an||
expression always evaluated to false because it was testing that the same byte is simultaneously equal to four different values, which is logically impossible without beingvolatile
(and if even if it werevolatile
it would almost certainly still be a bug).Instead, I believe the intention was to work like the left-hand expression, which tests four consecutive bytes. I've changed it to do that.
So I changed it from this
to this