Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync display name to Keycloak #57

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

davidgubler
Copy link
Member

@davidgubler davidgubler commented Aug 29, 2023

Summary

This PR adds the feature to sync organization displayNames to Keycloak.

See internal ticket APUB-523 for more information.

Copy link
Contributor

@bastjan bastjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct!

@davidgubler davidgubler merged commit 81537bb into master Aug 29, 2023
3 checks passed
@davidgubler
Copy link
Member Author

Thanks!

bastjan added a commit that referenced this pull request Oct 12, 2023
#57 changed the `keycloak.NewGroup` signature to take the first argument as the display name.
The teams controller was forgotten and the organization name was used as the display name and removed from the path.
This made the team look like an organization after syncing them to Keycloak.
bastjan added a commit that referenced this pull request Oct 12, 2023
#57 changed the `keycloak.NewGroup` signature to take the first argument as the display name. The teams controller was forgotten. The organization of the team was used as the display name and removed from the path. This made the team look like an organization after syncing them to Keycloak.
@bastjan bastjan deleted the display-name-sync branch October 12, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants