Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effort to update frex to 1.21.
List of things that need addressing (may not be exhaustive):
fabriquilt/src/main/java/io/vram/frex/pastel/mixin/MixinRenderRegionCache.java:135
- RenderRegionCache.isAllEmpty has been removed, do we just remove the mixin?common/src/main/java/io/vram/frex/mixin/MixinModelBakery.java:86
-@Redirect
mixin target seems to be incorrect. Also the actual mixin itself is questionablecommon/src/main/java/io/vram/frex/mixin/MixinModelBakery.java:116
- questionable; ModelBakery.loadModel has been removed (it seems that models are all always loaded during construction now)common/src/main/java/io/vram/frex/base/renderer/mesh/BaseQuadEmitter.java
- some methods in VertexConsumer have been removed (including but not limited to endVertex, defaultColor, addVertex/vertex with 14 parameters)common/src/main/java/io/vram/frex/impl/model/ModelProviderRegistryImpl.java:109
- ModelResourceLocation is now a record containing ResourceLocation, rather than a subclass of ResourceLocation.ModelProvider<ModelResourceLocation>
have been changed toModelProvider<ResourceLocation>
in other parts of the code. Do these need to be changed back to ModelResourceLocation (and ModelProvider T constraint changed?)common/src/main/java/io/vram/frex/pastel/PastelItemRenderContext.java:78
- ItemRenderer.getCompassFoilBufferDirect has been removed