Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat initial-cluster-size option in policy as an integer #950

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Treat initial-cluster-size option in policy as an integer #950

merged 1 commit into from
Oct 31, 2023

Conversation

jimmybigcommerce
Copy link
Contributor

Pull Request (PR) description

Similiar to #628, the policy setting initial-cluster-size needs to be parsed into an integer before being passed to RMQ.

Fixes this:

Error:
Validation failed

<<"3">> is not a valid cluster size

@jimmybigcommerce jimmybigcommerce force-pushed the initial_cluster_size_patch branch 2 times, most recently from 9fdfd0c to 1af1b2d Compare October 31, 2023 04:32
@wyardley wyardley added the bug Something isn't working label Oct 31, 2023
wyardley
wyardley approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@wyardley wyardley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
If it's not too much trouble, would you mind squashing all the commits one more time after that last suggestion?

I just did a release today, but will try to cut a release for this one fairly soon. If you want to take a stab at making the release PR, it will help:

https://voxpupuli.org/docs/releasing_version/

@jimmybigcommerce
Copy link
Contributor Author

LGTM If it's not too much trouble, would you mind squashing all the commits one more time after that last suggestion?

I just did a release today, but will try to cut a release for this one fairly soon. If you want to take a stab at making the release PR, it will help:

https://voxpupuli.org/docs/releasing_version/
@wyardley
Have squashed. I don't have perms to merge. If you merge it, I'll have a stab at the release

@wyardley wyardley merged commit c442d00 into voxpupuli:master Oct 31, 2023
6 checks passed
@jimmybigcommerce jimmybigcommerce deleted the initial_cluster_size_patch branch October 31, 2023 22:27
@jimmybigcommerce jimmybigcommerce mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyardley wyardley wyardley approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmybigcommerce @wyardley