Switch to string vs. symbols for facts in spec tests #1014
Merged
+27
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
force-pushed
the
wyardley/test_facts
branch
2 times, most recently
from
7b259a2
to
c32f0d4
Compare
TheMeier
approved these changes
Sep 6, 2024
bastelfreak
reviewed
Sep 6, 2024
wyardley
force-pushed
the
wyardley/test_facts
branch
3 times, most recently
from
f1ac63e
to
706ebcd
Compare
Set `facterdb_string_keys` to `true` and update to string versions of facts in our spec tests. Update `.sync.yml` so that modulesync doesn't override this while the default is still `false`
wyardley
force-pushed
the
wyardley/test_facts
branch
from
706ebcd
to
ba6260c
Compare
wyardley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
facterdb_string_keystotrueand update to string versions of facts in our spec tests.Update
.sync.ymlso that modulesync doesn't override this while the default is stillfalse