Support 2.5.x #200
Closed
Support 2.5.x #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackdpeterson
force-pushed
the
support_2.5.x
branch
from
27d5feb to
db9ccac
Compare
add trailing comma
jackdpeterson
force-pushed
the
support_2.5.x
branch
from
db9ccac to
9ac3cc3
Compare
traylenator
reviewed
Jun 6, 2023
| @@ -26,6 +28,16 @@ | |||
| } | |||
|
|
|||
| # Purge old/unnecessary repos. | |||
| if ($proxysql::version !~ /^2\.5\./) { | |||
There was a problem hiding this comment.
Would be good to add some tests for some of these version to yumrepo inclusion?
Just as a comment a bit of refactor might be good to get rid fo those $repo24, $repo25, ... . At a quick glance their contents looks pretty much identical.
There was a problem hiding this comment.
I'm not using CentOS / YUM based linux distributions; so I just copy/pasted w/ those textual changes to mimic what I see elsewhere.
jadestorm
pushed a commit
to ncstate-daniel/puppet-proxysql
that referenced
this pull request
Sep 19, 2023
|
Added with the merge of #216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of my last PR that adds support for 2.4.x by adding YUM and APT repository paths for these versions of ProxySQL.