Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for corosync v3 on RedHat/CentOS 8 #484

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for corosync v3 on RedHat/CentOS 8 #484

wants to merge 1 commit into from

Conversation

jake2184
Copy link

@jake2184 jake2184 commented Feb 24, 2020 •
edited
Loading

Pull Request (PR) description

Update the command used to check config file for corosync v3+

This Pull Request (PR) fixes the following issues

RedHat/CentOS 8 support

@bastelfreak
Copy link
Member

Sadly the tests are a bit flaky in this module :(

@vox-pupuli-tasks
Copy link

Dear @jake2184, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@damluk
Copy link

damluk commented May 6, 2020

Debian 10 has the same problem with validate_cmd.

ekohl
ekohl requested changes May 28, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be rebased once #446 is merged. After that it should also include EL8 in metadata.json so it gets tested. Ideally also add it to the acceptance tests.

@bastelfreak bastelfreak force-pushed the master branch 4 times, most recently from b2d3cf8 to ee89660 Compare December 29, 2020 11:49
@bastelfreak bastelfreak changed the title Support corosync v3 on RedHat8 Add support for corosync v3 on RedHat/CentOS 8 Dec 29, 2020
@towo towo mentioned this pull request Dec 29, 2020
Closed
@bastelfreak bastelfreak force-pushed the master branch 6 times, most recently from 7d58468 to d6f938c Compare December 29, 2020 16:05
@kajinamit
Copy link

Hello,

Is there any plan to resume this work ?

@vox-pupuli-tasks
Copy link

Dear @jake2184, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

This was referenced Jul 4, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl requested changes

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request merge-conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jake2184 @bastelfreak @damluk @kajinamit @ekohl