Merge pull request #61 from evgeni/proper-failure

properly fail the "Test Suite" check when any inputs are failing
voxpupuli · Aug 12, 2024 · 4e7257a · 4e7257a
2 parents c31ab2a + 18644e9
commit 4e7257a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/.github/workflows/basic.yml b/.github/workflows/basic.yml
@@ -101,9 +101,12 @@ jobs:
         run: bundle exec rake parallel_spec
 
   tests:
+    if: always()
     needs: unit
     runs-on: ubuntu-24.04
     name: Test suite
     steps:
-      - run: echo Test suite completed
-        working-directory: '.'
+      - name: Decide whether the needed jobs succeeded or failed
+        uses: re-actors/alls-green@release/v1
+        with:
+          jobs: ${{ toJSON(needs) }}
diff --git a/.github/workflows/beaker.yml b/.github/workflows/beaker.yml
@@ -181,12 +181,14 @@ jobs:
         env: ${{ matrix.env }}
 
   tests:
+    if: always()
     needs:
       - unit
       - acceptance
     runs-on: ubuntu-24.04
     name: Test suite
     steps:
-      - run: echo Test suite completed
-        # explicitly run at the root dir. In case people set working-directory this will otherwise fail (because this jobs doesn't clone the repo and the subdir doesn't exist)
-        working-directory: '.'
+      - name: Decide whether the needed jobs succeeded or failed
+        uses: re-actors/alls-green@release/v1
+        with:
+          jobs: ${{ toJSON(needs) }}