Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logging for signature string build error #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hansihe
Copy link

@hansihe hansihe commented Apr 29, 2024

No description provided.

@voltone
Copy link
Owner

voltone commented Apr 29, 2024

Thanks for your PR! It seems risky to inspect the exception, as the block in which the exception occurs has access to conn, which might contain information that should not be logged.

In general I try to avoid logging messages from code that can't be customized, as not everyone will have the same expectations of what should or should not be logged. So ideally any logging behaviour should live in the success or failure callbacks, so they can be customized by the user of the plug.

Is there any particular issue you ran into that resulted in a "could not build signature_string" error? Maybe we can improve the error handling within that function to (selectively) return a more detailed error, which can then be logged in the failure callback?

@hansihe
Copy link
Author

hansihe commented Apr 29, 2024

Sorry about this, I meant to open the PR on the fork itself, but I accidentally opened it on the upstream :)

I fully agree this should not be merged, this was meant to be used by us internally and temporarily to debug some issues in our system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants