Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update web manifest for WebAPK #952

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

StefanSchoof
Copy link
Contributor

@StefanSchoof StefanSchoof commented Nov 3, 2023

Update the web manifest for WebAPK installs for nicer icon on Android Homescreen
previous:
signal-2023-11-03-170935
with this change;
signal-2023-10-31-173556

Important: To have a WebAPK Install you need to serve the file over https and the ico folder need to be excluded from auth

@r00t-
Copy link
Contributor

r00t- commented Nov 9, 2023

LGTM but can't test.

@r00t-
Copy link
Contributor

r00t- commented Nov 9, 2023

To have a WebAPK Install you need to serve the file over https and the ico folder need to be excluded from auth

do we provide this setup to users, i.e. in the dockerfile (or does the raspberry pi image have this)?

@StefanSchoof
Copy link
Contributor Author

No, there is nothing provided. I use traefik with desec and letsencrypt and a google auth to have remote access to my volkszaehler. I share my config under https://github.com/StefanSchoof/traefik-config

I think having this in a image is not an easy task, because there are several other services you need to have configured.

@jahir
Copy link
Member

jahir commented Dec 1, 2023

LGTM

@jahir jahir merged commit fe3b919 into volkszaehler:master Dec 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants