Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filtering judgment for the kube_pod_volcano_container_status_runn… #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gsmini
Copy link

@gsmini gsmini commented Nov 7, 2024

in my actual use, I found that some pods without the 'volcano.sh/job-name' label also send 'kube_pod_volcano_container_resource_requests' and 'kube_pod_volcano_container_status_running' metrics to prometheus server.

kube_pod_volcano_container_resource_requests{
container="kube-state-metrics", 
endpoint="http-metrics", 
exported_container="etcd", 
exported_namespace="kube-system",
 exported_pod="etcd-ecs-165944-0001", 
instance="10.32.0.17:8080", job="kube-state-metrics", namespace="volcano-system", node="ecs-165944-0001", 
pod="kube-state-metrics-6769bc86fd-t42fk", 
resource="memory", service="kube-state-metrics",
 uid="4c151a5e-c0bb-47a4-be22-f734e1cbf295", unit="byte", volcano_namespace="kube-system"}

Therefore, based on the processing logic of metric 'kube_pod_volcano_container_resource_limits', i add the same pod label filtering for those two metrics as the 'kube_pod_volcano_container_resource_limits' do.

…ing and kube_pod_volcano_container_resource_requests metric

Signed-off-by: xiongyao <[email protected]>
@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants