F/aragondao handler #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigeon
force-pushed
the
f/aragondao-handler
branch
2 times, most recently
from
0db5b7d
to
d05229f
Compare
…, tokens and addressList DAOs
nigeon
force-pushed
the
f/aragondao-handler
branch
from
d05229f
to
f21a5b9
Compare
p4u
requested changes
Oct 23, 2023
| } | ||
|
|
||
| // Check if the address is an Aragon DAO address by checking to AragonGraphQL | ||
| if newRequest.Network != "" { |
There was a problem hiding this comment.
This is a bit weird, I'd either force the user to define network or not (and check all configured networks until one is found). Probably the second is easier for the UI side.
There was a problem hiding this comment.
The reason behind this is offering both possibilities,
- Searching in just one specific network
- Searching in any network
In the scaffold, we don't know (yet) the network that should be used (as it's "network-agnostic"). I think this is not the case for the Aragon Plugin.
Anyway, will ask about the logic to @jpaulet
nigeon
force-pushed
the
f/aragondao-handler
branch
from
05b64f7
to
eb15f0a
Compare
p4u
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added AragonDAO's handler for the faucet.
Works with multisig, token and addresslist daos.
Multi-network.