Adds support for stripe payments #14
Merged
+495
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
emmdim
force-pushed
the
f/stripe_support
branch
2 times, most recently
from
cef1f26 to
5332fa9
Compare
emmdim
force-pushed
the
f/stripe_support
branch
2 times, most recently
from
32cedb4 to
6dfc146
Compare
p4u
requested changes
Jun 5, 2024
p4u
requested changes
Jul 4, 2024
p4u
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Minor comments, please address them and feel free to merge it.
I have not checked the internal stripe logic (how it is the interaction with the stripe API and the security behind it). So I'd ask you to make a double check on this before the final merge.
Thank you and good job!
emmdim
force-pushed
the
f/stripe_support
branch
2 times, most recently
from
965073e to
1f2cad6
Compare
… process, assuming an embedded form, and a given stripe price id.
Refactors `storage`, `handlersresponse`, `faucet` and `helpers` to be new packages.
The min and max number of tokes is defined (should be paremtrized) and just aflat rate is allowed.
Adds the handlers:
- `/createCheckoutSession/{to}`
- `/createCheckoutSession/{to}/{amount}`
- `/sessionStatus/{session_id}`
- /webhook"
and the following env vars:
-STRIPEKEY
-STRIPEPRICEID
-STRIPEWEBHOOKSECRET
-STRIPEMINQUANTITY
-STRIPEMAXQUANTITY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables:
Relevant documentation:
https://docs.stripe.com/payments/checkout/how-checkout-works
https://docs.stripe.com/checkout/embedded/quickstart