feature: notifications #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmenendez
force-pushed
the
f/notifications
branch
from
55c4a21
to
395ba81
Compare
emmdim
requested changes
Sep 17, 2024
emmdim
reviewed
Sep 17, 2024
…sers and verifications packages
…to include some internal helpers like email format verification, password hashing or random generation
emmdim
requested changes
Sep 18, 2024
selankon
added a commit
to vocdoni/ui-scaffold
that referenced
this pull request
Sep 20, 2024
Depends on vocdoni/saas-backend#9 and needs #765 It implements the email verification page. - On signup page, once signup is success it shows an "verification email sent" message with a "resend email button" - On login page if the error of the backend is that the email is not verified, it shows the "verification email sent" message with a "resend email button" - Implements the route `/account/verify?email=${email}&code=xxxxxxx` - Performs an automatic verification attempt using a `useEffect` - If success redirect to `/organization` - Else show an error - **Resend verification mail mutation is implemented but won't work until implemented on the backend** In addition, it implements specific considerations for dev environments: - On signin page it shows a button to redirect to verify page without having verification code (because is not needed) - It permits empty verification codes on verify page (on dev envs they are not neeeded) An it fixes API function to: - throw plain text errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User notifications to verify email addresses or invite new admins to an organization. Via SMS and email.
Includes a testing email service. Support for no email service definition on boot allowing to verify users without code.
Now, when a new user registers, the account is created as unverified and the user receives a verification email. A new endpoint has been created to verify a user's account based on the user's email and the code sent.
There are also two new endpoints to request a user password recovery, which sends a code to the email provided to recover the associated password and reset the user password with that code.